Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【enhance】支持springboot war包方式启动 #975

Merged
merged 1 commit into from
Nov 25, 2022

Conversation

provenceee
Copy link
Collaborator

【修复issue】 #965

【修改内容】修改springboot启动类拦截点,放到SpringApplication的run方法中

【用例描述】用spring-boot-maven-plugin插件打成war包,能够进去SpringApplication拦截点

【自测情况】用spring-boot-maven-plugin插件打成war包,能够进去SpringApplication拦截点,dubbo可以注册

【影响范围】dubbo流控插件、dubbo路由插件、dubbo注册插件,springboot注册插件支持用spring-boot-maven-plugin打成war包

@provenceee provenceee self-assigned this Nov 25, 2022
@provenceee provenceee added kind/enhancement Issues or PRs releated to sermant enhancement area/plugin Issues or PRs releated to sermant plugin service labels Nov 25, 2022
@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Base: 44.50% // Head: 44.33% // Decreases project coverage by -0.17% ⚠️

Coverage data is based on head (fad2abb) compared to base (6133b39).
Patch coverage: 20.83% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #975      +/-   ##
=============================================
- Coverage      44.50%   44.33%   -0.18%     
+ Complexity      2805     2800       -5     
=============================================
  Files            660      660              
  Lines          14580    14613      +33     
  Branches        1620     1624       +4     
=============================================
- Hits            6489     6478      -11     
- Misses          7314     7356      +42     
- Partials         777      779       +2     
Flag Coverage Δ
unittests 44.33% <20.83%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../flowcontrol/config/SpringApplicationDeclarer.java 0.00% <0.00%> (ø)
...uter/dubbo/declarer/SpringApplicationDeclarer.java 0.00% <0.00%> (ø)
...ubbo/interceptor/SpringApplicationInterceptor.java 0.00% <0.00%> (ø)
...o/registry/declarer/SpringApplicationDeclarer.java 0.00% <0.00%> (ø)
...stry/interceptor/SpringApplicationInterceptor.java 0.00% <0.00%> (ø)
...owcontrol/config/SpringApplicationInterceptor.java 75.00% <83.33%> (ø)
...er/spring/interceptor/RouteHandlerInterceptor.java 0.00% <0.00%> (-80.96%) ⬇️
...nterceptors/DiscoveryClientServiceInterceptor.java 38.46% <0.00%> (-30.77%) ⬇️
...router/dubbo/strategy/type/ObjectTypeStrategy.java 71.42% <0.00%> (-14.29%) ⬇️
...mplement/service/tracing/sender/TracingSender.java 63.49% <0.00%> (-4.77%) ⬇️
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@provenceee provenceee changed the title 【支持springboot war包方式启动】 【enhance】支持springboot war包方式启动 Nov 25, 2022
@provenceee provenceee force-pushed the support-springboot-war branch from 53aa70e to b23f45e Compare November 25, 2022 07:31
@provenceee provenceee force-pushed the support-springboot-war branch from b23f45e to fad2abb Compare November 25, 2022 08:05
Copy link
Collaborator

@robotLJW robotLJW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@robotLJW robotLJW added this to the v0.8.0 milestone Nov 25, 2022
@robotLJW robotLJW added the status/lgtm Indicates that a PR is ready to be merged. label Nov 25, 2022
@robotLJW robotLJW merged commit 53eb7cc into sermant-io:develop Nov 25, 2022
@provenceee provenceee deleted the support-springboot-war branch November 26, 2022 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugin Issues or PRs releated to sermant plugin service kind/enhancement Issues or PRs releated to sermant enhancement status/lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants